oqyude/nifodea
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

T8: ISO 4217 per-currency decimals + format_money()

Browse Source 
- Add CURRENCY_DECIMALS dict (JPY=0, BHD/KWD/OMR=3, rest=2) and DEFAULT_CURRENCY_DECIMALS=2
- Add CurrencyConverter.format_money() staticmethod with ROUND_HALF_UP; symbol-prefix for known, code-prefix for unknown
- Replace 14 :,.2f literals across services.py / info.py / config_cmd.py with format_money() calls
- Refactor 2 i18n templates (transaction_add.ok, recurring_add.ok): {amount:.2f} -> {amount_str}; callers pass pre-formatted string
- New _account_currency() helper for transaction currency lookup
- Extend test_currency.py: 8 new tests (JPY/BHD/USD/CHF/negative/zero/float-int/lowercase)
- 75/75 tests pass; 0 :,.2f literals remain in infrastructure/cli/
This commit is contained in:
oqyude
2026-10-09 19:24:47 +03:00
parent 9175d5c76b
commit d58547e8f8
6 changed files with 136 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
infrastructure/cli/commands/info.py
+10 -5
View File
@@ -31,7 +31,7 @@ def info() -> None:
tbl.add_column(t("table.accounts.col.currency"))
tbl.add_column(t("table.accounts.col.balance"), justify="right")
for a in model.accounts:
tbl.add_row(a.name, a.currency, f"{a.balance:,.2f}")
tbl.add_row(a.name, a.currency, CurrencyConverter.format_money(a.balance, a.currency))
console.print(tbl)
if model.transactions:
@@ -41,7 +41,8 @@ def info() -> None:
tbl.add_column(t("table.transactions.col.amount"), justify="right")
tbl.add_column(t("table.transactions.col.description"))
for tx in model.transactions[:10]:
tbl.add_row(tx.date, tx.category, f"{tx.amount:,.2f}", tx.description)
amount_str = CurrencyConverter.format_money(tx.amount, model.base_currency)
tbl.add_row(tx.date, tx.category, amount_str, tx.description)
if len(model.transactions) > 10:
console.print(tbl)
console.print(t("cmd.info.more", count=len(model.transactions) - 10))
@@ -54,7 +55,8 @@ def info() -> None:
tbl.add_column(t("table.recurring.col.amount"), justify="right")
tbl.add_column(t("table.recurring.col.category"))
for r in model.recurring:
tbl.add_row(r.frequency, f"{r.amount:,.2f}", r.category)
amount_str = CurrencyConverter.format_money(r.amount, model.base_currency)
tbl.add_row(r.frequency, amount_str, r.category)
console.print(tbl)
if model.assets:
@@ -63,7 +65,8 @@ def info() -> None:
tbl.add_column(t("table.assets.col.value"), justify="right")
tbl.add_column(t("table.assets.col.growth"), justify="right")
for a in model.assets:
tbl.add_row(a.name, f"{a.value:,.2f}", f"{a.growth_rate:.1f}%")
value_str = CurrencyConverter.format_money(a.value, model.base_currency)
tbl.add_row(a.name, value_str, f"{a.growth_rate:.1f}%")
console.print(tbl)
if model.liabilities:
@@ -73,5 +76,7 @@ def info() -> None:
tbl.add_column(t("table.liabilities.col.rate"), justify="right")
tbl.add_column(t("table.liabilities.col.payment"), justify="right")
for li in model.liabilities:
tbl.add_row(li.name, f"{li.balance:,.2f}", f"{li.interest:.1f}%", f"{li.payment:,.2f}")
balance_str = CurrencyConverter.format_money(li.balance, model.base_currency)
payment_str = CurrencyConverter.format_money(li.payment, model.base_currency)
tbl.add_row(li.name, balance_str, f"{li.interest:.1f}%", payment_str)
console.print(tbl)